feat(ces): add security_settings to web_widget_config in google_ces_deployment#17264
Open
msvechla wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Open
feat(ces): add security_settings to web_widget_config in google_ces_deployment#17264msvechla wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
msvechla wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
…eployment Add the securitySettings.enablePublicAccess field to the webWidgetConfig block in the CES Deployment resource. This allows controlling whether a web widget deployment can be embedded without additional authentication directly via Terraform, removing the need for a local-exec workaround.
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
webWidgetConfigblock ingoogle_ces_deploymentis missingsecuritySettings, which the CES API supports. In particular,enablePublicAccesscontrols whether the web widget can be embedded without additional authentication.Without this field in the Terraform provider, users must resort to a
local-execworkaround to PATCH the deployment after creation/update. Addingsecurity_settingsas a native Terraform attribute eliminates this workaround.Changes
mmv1/products/ces/Deployment.yaml: AddsecuritySettingsnested object underwebWidgetConfigwithenablePublicAccessboolean fieldmmv1/templates/terraform/examples/ces_deployment_basic.tf.tmpl: Update example to showsecurity_settingsusageExample usage